wx.lib.masked.timectrl minor suggestion

Small suggestion, not sure if this list is where to mention it.
For wxTimeCtrl, this is the current GetValue() function:

GetValue(as_wxDateTime = False, as_mxDateTime = False,
      as_wxTimeSpan=False, as mxDateTimeDelta=False)

  Retrieves the value of the time from the control. By default this is
  returned as a string, unless one of the other arguments is set; args
  are searched in the order listed; only one value will be returned.

I thought it would be nice to have a flag for a regular
Python datetime, too.

Che

C M wrote:

Small suggestion, not sure if this list is where to mention it.
For wxTimeCtrl, this is the current GetValue() function:

GetValue(as_wxDateTime = False, as_mxDateTime = False,
      as_wxTimeSpan=False, as mxDateTimeDelta=False)

  Retrieves the value of the time from the control. By default this is
  returned as a string, unless one of the other arguments is set; args
  are searched in the order listed; only one value will be returned.

I thought it would be nice to have a flag for a regular
Python datetime, too.

Submit a patch.

···

--
Robin Dunn
Software Craftsman
http://wxPython.org Java give you jitters? Relax with wxPython!

C M wrote:

Small suggestion, not sure if this list is where to mention it.
For wxTimeCtrl, this is the current GetValue() function:

GetValue(as_wxDateTime = False, as_mxDateTime = False,
     as_wxTimeSpan=False, as mxDateTimeDelta=False)

Retrieves the value of the time from the control. By default this is
returned as a string, unless one of the other arguments is set; args
are searched in the order listed; only one value will be returned.

I thought it would be nice to have a flag for a regular
Python datetime, too.

Submit a patch.

--
Robin Dunn
Software Craftsman
http://wxPython.org Java give you jitters? Relax with wxPython!

I have never submitted a patch before and have really no idea how to
do it, but would like to at least to try. I just read the
"HowToSubmitPatches" page here:
http://trac.wxwidgets.org/wiki/HowToSubmitPatches

but have a few questions.

- For widgets that are in the lib subfolder of wxPython, are these
things that are only submitted as a patch for wxPython? This TimeCtrl
is in the subfolder wx.lib.masked, and it is written in Python, and
doesn't appear to be in the wxWidgets API, so I am assuming I submit
the patch against a development version of wxPython only?

- Is this the address for use with Trac for submitting the patch?
http://svn.wxwidgets.org/svn/wx/wxPython/trunk/

- Is there any other information for use with Trac to do this (password, etc)?

Thanks,
Che

···

On Fri, Feb 13, 2009 at 1:21 PM, Robin Dunn <robin@alldunn.com> wrote:

_______________________________________________
wxpython-users mailing list
wxpython-users@lists.wxwidgets.org
http://lists.wxwidgets.org/mailman/listinfo/wxpython-users

C M wrote:

I have never submitted a patch before and have really no idea how to
do it, but would like to at least to try. I just read the
"HowToSubmitPatches" page here:
wxTrac has been migrated to GitHub Issues - wxWidgets

but have a few questions.

- For widgets that are in the lib subfolder of wxPython, are these
things that are only submitted as a patch for wxPython? This TimeCtrl
is in the subfolder wx.lib.masked, and it is written in Python, and
doesn't appear to be in the wxWidgets API, so I am assuming I submit
the patch against a development version of wxPython only?

Yes, you only need to do the patch relative to the wxPython folder, and not worry about wxWidgets.

- Is this the address for use with Trac for submitting the patch?
http://svn.wxwidgets.org/svn/wx/wxPython/trunk/

That is what will become the 2.9 release. 2.8 is in http://svn.wxwidgets.org/svn/wx/wxPython/branches/WX_2_8_BRANCH/, although this code hasn't diverged much (if any) so the patch would probably be applicable to both.

- Is there any other information for use with Trac to do this (password, etc)?

You'll need to create and verify an account in Trac.

···

--
Robin Dunn
Software Craftsman
http://wxPython.org Java give you jitters? Relax with wxPython!