Phoenix findings wxPython-Phoenix-r73504-win32-py3.2

Ramin Sabet wrote:

Hi (Robin),

i was playing around to see if i can make my app run with python 3.2 ans
Phoenix, needed to make some changes in
wxPython-Phoenix-r73504-win32-py3.2, here are the patches:

Thanks. Did you also test that your changes are still compatible with Py2.7? I didn't see any issues when I scanned the patches but if you tested them with 2.7 then I wont worry about it.

The wx_lib_masked_ipaddrctrl.py.diff file is empty, was there supposed to be some changes there?

In the future please provide a single patch file for each set of changes and use either svn diff or git diff to generate the patch. That will make it much easier to apply. Also you can add some tags to the file header as described here[1] to indicate that the file has been ported.

[1] ProjectPhoenix/LibraryMigration - wxPyWiki

i am not using all the controls, so currently i only fixed the files
used in my project which i could test.

Ps.: after some work i found the following site:
https://bitbucket.org/amauryfa/wxpython-py3k wher some work has already
been done on these files.

Yes, it would be good to review those changes again. I wasn't ready to deal with them when they were first proposed, and it fell off of my radar after some time.

Please tell me if this is the proper way to suggest patches and keep up
the great work !

Sending them here is okay, as is creating a ticket for it at trac.wxwidgets.org.

···

--
Robin Dunn
Software Craftsman