Message to Robin Dunn

I found a solution to this problem...
try:
    from urllib2 import urlopen
except ImportError:
    from urllib.request import urlopen

The six module does not handle urllib and urllib2, so this is a temporary solution. Anyone has any other idea?

···

-----Original message-----
From: Cody
Sent: 18.03.2013, 16:13
To: wxpython-users@googlegroups.com
Subject: Re: [wxPython-users] Message to Robin Dunn

Hi,

On Mon, Mar 18, 2013 at 10:01 AM, "Boštjan Mejak" <mejak.bost@gmail.com>wrote:

Hello Robin,
you have suggested I patch Phoenix/wx/lib/softwareupdate.py when I
encountered an error on importing softwareupdate on Python 3. The error was
that softwareupdate uses urllib2 to perform Internet-related tasks. You
suggested the six module to patch softwareupdate, but the six docs say that
urllib and urllib2 aren't supported. So that's gonna be a burden. Are you
going to look at this and patch it?

urllib2 was merged into the urllib module in Python 3. So when running on
python 3 you would import and use urllib instead of urllib2.

Depending upon what features are used by the update module some additional
changes may be needed (see notes:
20.6. urllib2 — extensible library for opening URLs — Python 2.7.18 documentation). So guess the story is
either do some homework or be patient and wait till someone else gets to it
;).

Cody

--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Boštjan Mejak wrote:

I found a solution to this problem...
try:
     from urllib2 import urlopen
except ImportError:
     from urllib.request import urlopen

The six module does not handle urllib and urllib2, so this is a temporary solution. Anyone has any other idea?

That is one correct way to do it. Another correct way would be to use six.PY3

if six.PY3:
     from urllib.request import urlopen
else:
     from urllib2 import urlopen

···

--
Robin Dunn
Software Craftsman

I found a solution to this problem...
try:
    from urllib2 import urlopen
except ImportError:
    from urllib.request import urlopen

The six module does not handle urllib and urllib2, so this is a temporary solution. Anyone has any other idea?

Maybe something like this (no error catching):

import wx.lib.six as six

if six.PY3:
     from urllib.request import urlopen
else:
    from urllib2 import urlopen

···

On 18 March 2013 17:55, "Boštjan Mejak" wrote:

-----Original message-----
From: Cody
Sent: 18.03.2013, 16:13
To: wxpython-users@googlegroups.com
Subject: Re: [wxPython-users] Message to Robin Dunn

Hi,

On Mon, Mar 18, 2013 at 10:01 AM, "Boštjan Mejak" <mejak.bost@gmail.com>wrote:

Hello Robin,
you have suggested I patch Phoenix/wx/lib/softwareupdate.py when I
encountered an error on importing softwareupdate on Python 3. The error was
that softwareupdate uses urllib2 to perform Internet-related tasks. You
suggested the six module to patch softwareupdate, but the six docs say that
urllib and urllib2 aren't supported. So that's gonna be a burden. Are you
going to look at this and patch it?

urllib2 was merged into the urllib module in Python 3. So when running on
python 3 you would import and use urllib instead of urllib2.

Depending upon what features are used by the update module some additional
changes may be needed (see notes:
20.6. urllib2 — extensible library for opening URLs — Python 2.7.18 documentation). So guess the story is
either do some homework or be patient and wait till someone else gets to it
;).

Cody

--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
Andrea.

"Imagination Is The Only Weapon In The War Against Reality."

# ------------------------------------------------------------- #
def ask_mailing_list_support(email):

    if mention_platform_and_version() and include_sample_app():
        send_message(email)
    else:
        install_malware()
        erase_hard_drives()
# ------------------------------------------------------------- #

Thanks for your replies, Robin and Andrea. Would you mind telling me what the Phoenix/wx/lib/softwareupdate.py is actually for? And if it’s not too important keeping it around, we can remove it from future Phoenix source code. What do you say about that?

Bo�tjan Mejak wrote:

Thanks for your replies, Robin and Andrea. Would you mind telling me
what the Phoenix/wx/lib/softwareupdate.py is actually for?

Did you even think about reading the comments and the docstring in the module so you could answer that question for yourself?

If you don't even know what it is, why are you so worried about it? If you don't need it then don't import it in your code.

And if it's
not too important keeping it around, we can remove it from future
Phoenix source code. What do you say about that?

No.

···

--
Robin Dunn
Software Craftsman