Makefile bug

Hi Robin,

    There is a bug in wxPython makefile. In fact it is in wxWidget's
makefile. On line 12046 you forgot to add $(DESTDIR) before $(libdir).
That line must be like this:

(cd $(DESTDIR)$(bindir) && rm -f wx-config && $(LN_S)
$(DESTDIR)$(libdir)/wx/config/$(TOOLCHAIN_FULLNAME) wx-config)

I have faced this bug while making a slackware package.

Oops sorry I have misunderstood it

···

2007/1/26, Murat Erten <murerten@gmail.com>:

Hi Robin,

    There is a bug in wxPython makefile. In fact it is in wxWidget's
makefile. On line 12046 you forgot to add $(DESTDIR) before $(libdir).
That line must be like this:

(cd $(DESTDIR)$(bindir) && rm -f wx-config && $(LN_S)
$(DESTDIR)$(libdir)/wx/config/$(TOOLCHAIN_FULLNAME) wx-config)

I have faced this bug while making a slackware package.

But after rethinking it can be a bug. I can't make install wxWidgets
using DESTDIR. What do you think ?

···

2007/1/26, Murat Erten <murerten@gmail.com>:

2007/1/26, Murat Erten <murerten@gmail.com>:
> Hi Robin,
>
> There is a bug in wxPython makefile. In fact it is in wxWidget's
> makefile. On line 12046 you forgot to add $(DESTDIR) before $(libdir).
> That line must be like this:
>
> (cd $(DESTDIR)$(bindir) && rm -f wx-config && $(LN_S)
> $(DESTDIR)$(libdir)/wx/config/$(TOOLCHAIN_FULLNAME) wx-config)
>
> I have faced this bug while making a slackware package.
>

Oops sorry I have misunderstood it

Murat Erten wrote:

···

2007/1/26, Murat Erten <murerten@gmail.com>:

2007/1/26, Murat Erten <murerten@gmail.com>:
> Hi Robin,
>
> There is a bug in wxPython makefile. In fact it is in wxWidget's
> makefile. On line 12046 you forgot to add $(DESTDIR) before $(libdir).
> That line must be like this:
>
> (cd $(DESTDIR)$(bindir) && rm -f wx-config && $(LN_S)
> $(DESTDIR)$(libdir)/wx/config/$(TOOLCHAIN_FULLNAME) wx-config)
>
> I have faced this bug while making a slackware package.
>

Oops sorry I have misunderstood it

But after rethinking it can be a bug. I can't make install wxWidgets
using DESTDIR. What do you think ?

I think you may be right. You should submit a patch and see what the other developers think. Note that since Makefile.in is generated via bakefile then you'll need to make the change in build/bakefiles/wx.bkl.

--
Robin Dunn
Software Craftsman
http://wxPython.org Java give you jitters? Relax with wxPython!

I really apologize for bothering you. It was my mistake. There is not
a bug in makefile.

···

2007/1/27, Robin Dunn <robin@alldunn.com>:

Murat Erten wrote:
> 2007/1/26, Murat Erten <murerten@gmail.com>:
>> 2007/1/26, Murat Erten <murerten@gmail.com>:
>> > Hi Robin,
>> >
>> > There is a bug in wxPython makefile. In fact it is in wxWidget's
>> > makefile. On line 12046 you forgot to add $(DESTDIR) before $(libdir).
>> > That line must be like this:
>> >
>> > (cd $(DESTDIR)$(bindir) && rm -f wx-config && $(LN_S)
>> > $(DESTDIR)$(libdir)/wx/config/$(TOOLCHAIN_FULLNAME) wx-config)
>> >
>> > I have faced this bug while making a slackware package.
>> >
>>
>> Oops sorry I have misunderstood it
>>
>
> But after rethinking it can be a bug. I can't make install wxWidgets
> using DESTDIR. What do you think ?

I think you may be right. You should submit a patch and see what the
other developers think. Note that since Makefile.in is generated via
bakefile then you'll need to make the change in build/bakefiles/wx.bkl.

--
Robin Dunn
Software Craftsman
http://wxPython.org Java give you jitters? Relax with wxPython!

---------------------------------------------------------------------
To unsubscribe, e-mail: wxPython-users-unsubscribe@lists.wxwidgets.org
For additional commands, e-mail: wxPython-users-help@lists.wxwidgets.org