Is the slice notation [11:-2] needed at all?
Bo�tjan Mejak wrote:
Is the slice notation [11:-2] needed at all?
That will slice out just the revision number from the substituted value, so __revision__ would be just the number without a label in front of it.
···
--
Robin Dunn
Software Craftsman
I see. But I, myself, kind of dislike hardcoded things. And the revision numbering scheme may change in the future, so it would be nice if “$Revision$” would output just the number. Or is that VCS-dependant?
···
On Wed, May 29, 2013 at 6:45 PM, Robin Dunn robin@alldunn.com wrote:
Boštjan Mejak wrote:
Is the slice notation [11:-2] needed at all?
That will slice out just the revision number from the substituted value, so revision would be just the number without a label in front of it.
–
Robin Dunn
Software Craftsman
–
You received this message because you are subscribed to the Google Groups “wxPython-users” group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
*CVS-dependant
···
On Wed, May 29, 2013 at 9:16 PM, Boštjan Mejak mejak.bost@gmail.com wrote:
I see. But I, myself, kind of dislike hardcoded things. And the revision numbering scheme may change in the future, so it would be nice if “$Revision$” would output just the number. Or is that VCS-dependant?
On Wed, May 29, 2013 at 6:45 PM, Robin Dunn robin@alldunn.com wrote:
Boštjan Mejak wrote:
Is the slice notation [11:-2] needed at all?
That will slice out just the revision number from the substituted value, so revision would be just the number without a label in front of it.
–
Robin Dunn
Software Craftsman
–
You received this message because you are subscribed to the Google Groups “wxPython-users” group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Boštjan Mejak wrote:
I see. But I, myself, kind of dislike hardcoded things. And the
revision numbering scheme may change in the future, so it would be
nice if "$Revision$" would output just the number. Or is that
VCS-dependant?
Exactly. That's the point. The $Revision$ string is expanded by the
source control system. The [11:-2] thing is specifically for CVS.
···
--
Tim Roberts, timr@probo.com
Providenza & Boekelheide, Inc.
Robin, is my patch ready for being commited to the trunk?
Bo�tjan Mejak wrote:
Robin, is my patch ready for being commited to the trunk?
I've committed it locally, it will be pushed up to SVN later.
Next time please test your changes with both Py3 and Py2.7. If you had done that this time then you would have realized that six.string_types() is not what should be used as a replacement for str(). Instead, six.text_type() should be used for that and six.string_types should be used with isinstance.
···
--
Robin Dunn
Software Craftsman
I’ll keep that in mind. Thanks for sharing that. Anyway, I hope my patch helps you in some way. If there are any other modules that need porting to Python 3 and be Python 2.x-compatible, list them here and I’ll see what I can do.
···
On Fri, May 31, 2013 at 6:26 PM, Robin Dunn robin@alldunn.com wrote:
Boštjan Mejak wrote:
Robin, is my patch ready for being commited to the trunk?
I’ve committed it locally, it will be pushed up to SVN later.
Next time please test your changes with both Py3 and Py2.7. If you had done that this time then you would have realized that six.string_types() is not what should be used as a replacement for str(). Instead, six.text_type() should be used for that and six.string_types should be used with isinstance.
–
Robin Dunn
Software Craftsman
–
You received this message because you are subscribed to the Google Groups “wxPython-users” group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
I tested the Phoenix snapshot build r74085 on Windows 7 x64 for Python 3.3 after my patch from this thread was commited. There’s a SyntaxError now if you run a program that has the InspectionMixin mixed with App. I fixed my snapshot build to the state that the Widget Inspection Tool is perfectly working now and I am posting a patch for the source code that I grabbed from GitHub. I had to fix filling.py and also a little fix needed to be made in inspection.py.
Please review and commit. 
inspection_and_filling.patch (2.27 KB)
How did the tests with 2.x turn out ?
Karsten
···
On Sun, Jun 02, 2013 at 08:38:33AM -0700, Boštjan Mejak wrote:
I tested the Phoenix snapshot build r74085 on Windows 7 x64 for Python 3.3
I had to fix filling.py and also a little fix needed to be
made in inspection.py.
--
GPG key ID E4071346 @ gpg-keyserver.de
E167 67FD A291 2BEA 73BD 4537 78B9 A9F9 E407 1346
Boštjan Mejak wrote:
I'll keep that in mind. Thanks for sharing that. Anyway, I hope my patch
helps you in some way. If there are any other modules that need porting
to Python 3 and be Python 2.x-compatible, list them here and I'll see
what I can do.
All of them that do not have a "py3-port" tag.
···
--
Robin Dunn
Software Craftsman
Bo�tjan Mejak wrote:
I tested the Phoenix snapshot build r74085 on Windows 7 x64 for Python
3.3 after my patch from this thread was commited. There's a SyntaxError
now if you run a program that has the InspectionMixin mixed with App. I
fixed my snapshot build to the state that the Widget Inspection Tool is
perfectly working now and I am posting a patch for the source code that
I grabbed from GitHub. I had to fix filling.py and also a little fix
needed to be made in inspection.py.Please review and commit.
Thanks.
···
--
Robin Dunn
Software Craftsman
Was my patch inspection_and_filling.patch commited locally only? 'Cause I don’t see my changes in the source.
Hi,
···
On 04/06/2013 15:28, Bo�tjan Mejak wrote:
Was my patch inspection_and_filling.patch commited locally only? 'Cause I don't see my changes in the source.
You can see what is committed here:
or in the SVN repo.
Depending on Robin's work load, his testing on different platforms and different ..... it can take some time.
Werner
It’s interesting that my newest patch was not yet commited.
Gotta link to the SVN repo?
Bo�tjan Mejak wrote:
Was my patch inspection_and_filling.patch commited locally only? 'Cause
I don't see my changes in the source.
Sorry. I had it ready to go but forgot to merge that branch before pushing to the subversion repository. It's there now.
···
--
Robin Dunn
Software Craftsman
Robin commits to his work and does whatever he does and at some point he commits to the public repo.
What is your problem with that?
Anyhow you have your patch applied to your code and can work with it, others who absolutely have to have it can apply it to their code and work with it.
Werner
P.S.
The SVN repo is the one where all the wxWidget code is in which you can find on the wxPython home page somewhere.
···
On 04/06/2013 18:04, Bo�tjan Mejak wrote:
It's interesting that my newest patch was not yet commited.
Yup, there it is. Thanks, Robin. If I stumble upon any other bug, I’ll fix the source and give you the patch via this mailing list.
The patch fixes the boolean evaluation order in filling.py.
filling.patch (748 Bytes)