Small Phoenix Patchs

Patch #1.
In agw.artmanager the LightColour and DarkColour defs are complaining about colour values not being integers…

changing
return wx.Colour(r, g, b)
to
return wx.Colour(int®, int(g), int(b))

fixes this small problem.

Unresolved Issue: Undocking Panes.

···

==========================

Traceback (most recent call last):
File “C:\Python27\lib\site-packages\wx-2.9.5-phoenix\wx\lib\agw\aui\framemanager.py”, line 9220, in OnMotion
self.OnMotion_ClickCaption(event)
File “C:\Python27\lib\site-packages\wx-2.9.5-phoenix\wx\lib\agw\aui\framemanager.py”, line 9392, in OnMotion_ClickCapt
ion
self.Update()
File “C:\Python27\lib\site-packages\wx-2.9.5-phoenix\wx\lib\agw\aui\framemanager.py”, line 6469, in Update
pFrame.SetIcon(wx.Icon(p.icon))
TypeError: Icon(): arguments did not match any overloaded call:
overload 1: too many arguments
overload 2: argument 1 has unexpected type ‘Bitmap’
overload 3: argument 1 has unexpected type ‘Bitmap’
overload 4: argument 1 has unexpected type ‘Bitmap’

At that point p.icon is:
type(p.icon)
<class ‘wx._core.Bitmap’>
Maybe wx.Icon is missing an overloaded implementation to deal with a
bitmap?
Werner

···

On 03/06/2013 06:57, Metallicow wrote:

Unresolved Issue: Undocking Panes.

  ==========================

Traceback (most recent call last):

      File

“C:\Python27\lib\site-packages\wx-2.9.5-phoenix\wx\lib\agw\aui\framemanager.py”,
line 9220, in OnMotion

        self.OnMotion_ClickCaption(event)

      File

“C:\Python27\lib\site-packages\wx-2.9.5-phoenix\wx\lib\agw\aui\framemanager.py”,
line 9392, in OnMotion_ClickCapt

    ion

        self.Update()

      File

“C:\Python27\lib\site-packages\wx-2.9.5-phoenix\wx\lib\agw\aui\framemanager.py”,
line 6469, in Update

        pFrame.SetIcon(wx.Icon(p.icon))

    TypeError: Icon(): arguments did not match any overloaded call:

      overload 1: too many arguments

      overload 2: argument 1 has unexpected type 'Bitmap'

      overload 3: argument 1 has unexpected type 'Bitmap'

      overload 4: argument 1 has unexpected type 'Bitmap'

@ Werner: That is probably the case. It might need another implementation.

I couldn’t get anything I tried to work.

Basically a convert Bitmap <==> Icon function, trying to deal with the trace…

I think it is there in wx but probably needs some tweaking by Robin to enable it.

Werner

···

On 03/06/2013 08:38, Metallicow wrote:

@ Werner: That is probably the case. It might need another implementation.

werner wrote:

···

On 03/06/2013 08:38, Metallicow wrote:

@ Werner: That is probably the case. It might need another
implementation.

I think it is there in wx but probably needs some tweaking by Robin to
enable it.

Actually it was grafted on after the fact by wxPython Classic, but I misremembered and also thought that was built-in, so I didn't think of grafting it on for Phoenix too.

Fixed now.

--
Robin Dunn
Software Craftsman

Metallicow wrote:

Patch #1.
In agw.artmanager the LightColour and DarkColour defs are complaining
about colour values not being integers...

changing
return wx.Colour(r, g, b)
to
return wx.Colour(int(r), int(g), int(b))

fixes this small problem.

Thanks.

Next time please make a proper patch file (easiest way is running 'svn diff' or 'git diff' from a local checked out copy of the current code.)

···

--
Robin Dunn
Software Craftsman