Can I propose for Phoenix that we change wx.lib.embeddedimage.PyEmbeddedImage to wx.lib.embeddedimage.EmbeddedImage, so cutting the Py prefix? And then just make an alias PyEmbeddedImage = EmbeddedImage for backwards-compatibility sake?
Why?
Is this the most important issue that needs to be addressed to bring
Phoenix up to speed and at the same level of Classic?
Andrea.
"Imagination Is The Only Weapon In The War Against Reality."
# ------------------------------------------------------------- #
def ask_mailing_list_support(email):
if mention_platform_and_version() and include_sample_app():
send_message(email)
else:
install_malware()
erase_hard_drives()
# ------------------------------------------------------------- #
···
On 22 April 2013 13:40, "Boštjan Mejak" wrote:
Can I propose for Phoenix that we change
wx.lib.embeddedimage.PyEmbeddedImage to wx.lib.embeddedimage.EmbeddedImage,
so cutting the Py prefix? And then just make an alias PyEmbeddedImage =
EmbeddedImage for backwards-compatibility sake?
I see that in Phoenix a lot of those Py prefixes were removed, so I am merely proposing we remove the Py prefix for PyEmbeddedImage as well.
···
On Mon, Apr 22, 2013 at 2:00 PM, Andrea Gavana andrea.gavana@gmail.com wrote:
–
You received this message because you are subscribed to the Google Groups “wxPython-users” group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
On 22 April 2013 13:40, “Boštjan Mejak” wrote:
Can I propose for Phoenix that we change wx.lib.embeddedimage.PyEmbeddedImage to wx.lib.embeddedimage.EmbeddedImage, so cutting the Py prefix? And then just make an alias PyEmbeddedImage = EmbeddedImage for backwards-compatibility sake?
Why?
Is this the most important issue that needs to be addressed to bring Phoenix up to speed and at the same level of Classic?
Andrea.
“Imagination Is The Only Weapon In The War Against Reality.”
http://www.infinity77.net
-------------------------------------------------------------
def ask_mailing_list_support(email):
if mention_platform_and_version() and include_sample_app():
send_message(email)
else:
install_malware()
erase_hard_drives()
-------------------------------------------------------------
No, but a major overhaul like this is the perfect time to make these
kinds of aesthetic changes. Consistency does have some value.
···
Andrea Gavana wrote:
On 22 April 2013 13:40, "Boštjan Mejak"wrote:
Can I propose for Phoenix that we changewx.lib.embeddedimage.PyEmbeddedImage to
wx.lib.embeddedimage.EmbeddedImage, so cutting the Py
prefix? And then just make an alias PyEmbeddedImage =
EmbeddedImage for backwards-compatibility sake?
Why?
Is this the most important issue that needs tobe addressed to bring Phoenix up to speed and at the same
level of Classic?
-- Tim Roberts, Providenza & Boekelheide, Inc.
I’m with Tim on this one. It’s not a big deal changing the class’ name and make an alias for it. I can make a patch for this, but it’ll take longer than you fixing this directly, since you can commit and I can’t.
···
On Mon, Apr 22, 2013 at 7:23 PM, Tim Roberts timr@probo.com wrote:
Andrea Gavana wrote:
-- Tim Roberts, timr@probo.com Providenza & Boekelheide, Inc.No, but a major overhaul like this is the perfect time to make thesekinds of aesthetic changes. Consistency does have some value.
–
You received this message because you are subscribed to the Google Groups “wxPython-users” group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
On 22 April 2013 13:40, "Boštjan Mejak"
wrote:
Can I propose for Phoenix that we changewx.lib.embeddedimage.PyEmbeddedImage to
wx.lib.embeddedimage.EmbeddedImage, so cutting the Py
prefix? And then just make an alias PyEmbeddedImage =
EmbeddedImage for backwards-compatibility sake?
Why?
Is this the most important issue that needs to
be addressed to bring Phoenix up to speed and at the same
level of Classic?
I think that is a very weak excuse to make a patch;-) .
But I think the patch should be more then just this rename if you want to do it you should also do the unittest for this module/class and probably have a test to make sure that both names work and then you should also update/create the documentation strings for the module, class and all public methods and last but not least I think at least the most obvious users of PyEmbeddedImage should be changed too, this includes at least tools/img2py.py.
Just my 0.02€
Werner
···
On 22/04/2013 21:20, Boštjan Mejak wrote:
I'm with Tim on this one. It's not a big deal changing the class' name and make an alias for it. I can make a patch for this, but it'll take longer than you fixing this directly, since you can commit and I can't.
Bo�tjan Mejak wrote:
Can I propose for Phoenix that we change wx.lib.embeddedimage.PyEmbeddedImage to wx.lib.embeddedimage.EmbeddedImage, so cutting the Py prefix? And then just make an alias PyEmbeddedImage = EmbeddedImage for backwards-compatibility sake?
In this case the Py prefix was not used for the same reason as most of the others. "PyEmbeddedImage" was intended to be a shortened version of "Image data embedded in Python code" or "Python-embedded Image" so I think I'm going to leave this one as-is.
···
--
Robin Dunn
Software Craftsman