I think that the focus rectangle that gets drawn on the tabs would
look slightly more proper on OSX if it was drawn on the border of the
tab as opposed as just a bounding box around the tabs label.
It would also be nice to have an option to disable the tab area from
being able to receiving the focus at all / not drawing a focus
rectangle on the tab). Sometime its nice to disallow this in order to
make sure that the page owned by the tab gets the focus and not the
tab itself to reduce the number of mouse clicks needed in an
interface.
I think that the focus rectangle that gets drawn on the tabs would
look slightly more proper on OSX if it was drawn on the border of the
tab as opposed as just a bounding box around the tabs label.
It would also be nice to have an option to disable the tab area from
being able to receiving the focus at all / not drawing a focus
rectangle on the tab). Sometime its nice to disallow this in order to
make sure that the page owned by the tab gets the focus and not the
tab itself to reduce the number of mouse clicks needed in an
interface.
Please enter a bug report/feature request on wxTrac for this. It's a
pretty busy period this one, so if you can manage to create a patch
implementing these features it would be more than welcome.
FWIW, I've locally made changes to FlatNotebook so that it doesn't draw the focus rectangle, as I don't think it is correct on Mac, as AFAICT a focus rect always indicates an editable control. I also adjusted the icon display, as at least on Mac it was a little too low and was drawing the icon on top of the tab's bottom border.
I also need to fix the fact that the tabs get the focus, as this creates a problem when you try to set the focus to one of the page's child controls in response to a PAGE_CHANGED event. The focus does change, as it should, but then on mouse up the tab steals the focus from back the child control. (IMHO this should probably be changed for all platforms.)
If these changes are desired I can land them in wxPython trunk and 2.8 branches too. I don't know if PyAuiNotebook is using FlatNotebook, but since the issues sound the same I suspect there is some overlap.
Thanks,
Kevin
···
On Feb 25, 2010, at 11:28 AM, Cody Precord wrote:
Hi Andrea,
I think that the focus rectangle that gets drawn on the tabs would
look slightly more proper on OSX if it was drawn on the border of the
tab as opposed as just a bounding box around the tabs label.
It would also be nice to have an option to disable the tab area from
being able to receiving the focus at all / not drawing a focus
rectangle on the tab). Sometime its nice to disallow this in order to
make sure that the page owned by the tab gets the focus and not the
tab itself to reduce the number of mouse clicks needed in an
interface.
On Feb 25, 2010, at 5:17 PM, Kevin Ollivier wrote:
Hi Cody and all,
FWIW, I've locally made changes to FlatNotebook so that it doesn't draw the focus rectangle, as I don't think it is correct on Mac, as AFAICT a focus rect always indicates an editable control. I also adjusted the icon display, as at least on Mac it was a little too low and was drawing the icon on top of the tab's bottom border.
I also need to fix the fact that the tabs get the focus, as this creates a problem when you try to set the focus to one of the page's child controls in response to a PAGE_CHANGED event. The focus does change, as it should, but then on mouse up the tab steals the focus from back the child control. (IMHO this should probably be changed for all platforms.)
If these changes are desired I can land them in wxPython trunk and 2.8 branches too. I don't know if PyAuiNotebook is using FlatNotebook, but since the issues sound the same I suspect there is some overlap.
Funny, I made pretty much the same changes in my local copy of fnb as well, plus a few more for the navigation arrows.
The AuiNotebook is different, though some of the code appears to have been adapted from the fnb to it.