Since you're back around more, a couple of questions:
1) Can you merge PRs 45 and 68 first? They fix a couple of recent regressions.
2) Can the buildbots be made to run and show unittest results? It would be quite helpful to know the current test state on all platforms, and be able to see when regressions occur.
3) Is there a reason you're using a separate branch of wxWidgets and not the WX_3_0_BRANCH? It would seem that if any fixes are needed for Phoenix, they ought to just go right upstream.
Since you're back around more, a couple of questions:
1) Can you merge PRs 45 and 68 first? They fix a couple of recent
regressions.
Yep. I got through the rest of the "newish" PRs today and have merged them.
2) Can the buildbots be made to run and show unittest results? It would
be quite helpful to know the current test state on all platforms, and be
able to see when regressions occur.
That is the intent, but last time I tried it I ran into a problem which I think had something to do with the build slave's environment if I remember correctly. I didn't have time then to pursue the issue further, but it is something that I'll try to get going again. I'm also experiencing some hard crashes when running all of the tests at once on OSX, but running them a few at a time passes, so that needs figuring out too.
3) Is there a reason you're using a separate branch of wxWidgets and not
the WX_3_0_BRANCH? It would seem that if any fixes are needed for
Phoenix, they ought to just go right upstream.
It started with one patch that was not getting any attention from the wx dev, and then as I fell behind on my wx mail lists and stuff it was just easier to keep adding things to my own branch and merging WX_3_0_BRANCH into it periodically. I do plan on getting it all merged in eventually however.
Yeah, I understand now what you're talking about. I've been trying to get all the tests to run (ie, not crash) on GTK3 too. It has been a challenge.
Scott
···
On Mon, 9 May 2016, Robin Dunn wrote:
2) Can the buildbots be made to run and show unittest results? It would
be quite helpful to know the current test state on all platforms, and be
able to see when regressions occur.
That is the intent, but last time I tried it I ran into a problem which I think had something to do with the build slave's environment if I remember correctly. I didn't have time then to pursue the issue further, but it is something that I'll try to get going again. I'm also experiencing some hard crashes when running all of the tests at once on OSX, but running them a few at a time passes, so that needs figuring out too.
Don't you have commit rights to wxWidgets? If so, couldn't you just make your fixes directly to WX_3_0_BRANCH?
If not, do you have any issues if I pursue getting at least some of your patches merged?
Scott
···
On Mon, 9 May 2016, Robin Dunn wrote:
3) Is there a reason you're using a separate branch of wxWidgets and not
the WX_3_0_BRANCH? It would seem that if any fixes are needed for
Phoenix, they ought to just go right upstream.
It started with one patch that was not getting any attention from the wx dev, and then as I fell behind on my wx mail lists and stuff it was just easier to keep adding things to my own branch and merging WX_3_0_BRANCH into it periodically. I do plan on getting it all merged in eventually however.
3) Is there a reason you're using a separate branch of wxWidgets and not
the WX_3_0_BRANCH? It would seem that if any fixes are needed for
Phoenix, they ought to just go right upstream.
It started with one patch that was not getting any attention from the wx dev, and then as I fell behind on my wx mail lists and stuff it was just easier to keep adding things to my own branch and merging WX_3_0_BRANCH into it periodically. I do plan on getting it all merged in eventually however.
Don't you have commit rights to wxWidgets? If so, couldn't you just make your fixes directly to WX_3_0_BRANCH?
I do, and I will work on merging them at latest by the time Phoenix is ready for alpha, but there is a little more to it than that. Some of the changes will need discussion on wx-dev, some will need further polishing, and most will need to be ported to the master branch as well. So yes, it will happen, but I'd rather wait until I can focus on that effort like I am focusing on Phoenix now.
Actually, I'm more concerned about the changes making it into wxWidgets 3.0.3, which is supposedly coming soon (although it has been in that state for a while). Distributions don't generally use the bundled wxWidgets, so the less patches that have to be applied, the better.
Scott
···
On Fri, 22 Jul 2016, Robin Dunn wrote:
3) Is there a reason you're using a separate branch of wxWidgets and not
the WX_3_0_BRANCH? It would seem that if any fixes are needed for
Phoenix, they ought to just go right upstream.
It started with one patch that was not getting any attention from the wx dev, and then as I fell behind on my wx mail lists and stuff it was just easier to keep adding things to my own branch and merging WX_3_0_BRANCH into it periodically. I do plan on getting it all merged in eventually however.
Don't you have commit rights to wxWidgets? If so, couldn't you just make your fixes directly to WX_3_0_BRANCH?
I do, and I will work on merging them at latest by the time Phoenix is ready for alpha, but there is a little more to it than that. Some of the changes will need discussion on wx-dev, some will need further polishing, and most will need to be ported to the master branch as well. So yes, it will happen, but I'd rather wait until I can focus on that effort like I am focusing on Phoenix now.
