numctrl "bold" issue

wxPython Dev
1

Hi Robin,

I am not finding an solution for that one, except maybe the following suggestion.

Currently the mask controls use useFixedWidthFont=True as the default, so what about switching it to "False"?

In my own stuff I use "False" (for a long time) as otherwise the masked controls use a different font then the other controls, which doesn't look great.

Werner

2

I think that would probably be okay. Can you make a patch that also updates the docstrings regarding the useFixedWidthFont default functionality.

···

On 12/26/12 11:37 PM, Werner wrote:

Hi Robin,

I am not finding an solution for that one, except maybe the following
suggestion.

Currently the mask controls use useFixedWidthFont=True as the default,
so what about switching it to "False"?

In my own stuff I use "False" (for a long time) as otherwise the masked
controls use a different font then the other controls, which doesn't
look great.

--
Robin Dunn
Software Craftsman

3

Will work on that, shouldn't take too long if I don't run into issues.

Werner

···

On 27/12/2012 22:41, Robin Dunn wrote:

On 12/26/12 11:37 PM, Werner wrote:

Hi Robin,

I am not finding an solution for that one, except maybe the following
suggestion.

Currently the mask controls use useFixedWidthFont=True as the default,
so what about switching it to "False"?

In my own stuff I use "False" (for a long time) as otherwise the masked
controls use a different font then the other controls, which doesn't
look great.

I think that would probably be okay. Can you make a patch that also updates the docstrings regarding the useFixedWidthFont default functionality.

4

What do I change?

All masked controls or just numctrl? I have done the later at the moment as some multi field controls are behaving a bit odd if changed, i.e. the field is smaller then expected and growth when one types something into them.

There also is a problem with timectrl e.g. "12:30" is not accepted, actually I can't find a value which is accepted for the time controls.

The problem also is there with SVN 2.9.5 and in 2.9.4 but it works in 2.8.12 - will keep searching but if someone has a hint that would be great.

Werner

···

On 27/12/2012 22:50, Werner wrote:

On 27/12/2012 22:41, Robin Dunn wrote:

On 12/26/12 11:37 PM, Werner wrote:

Hi Robin,

I am not finding an solution for that one, except maybe the following
suggestion.

Currently the mask controls use useFixedWidthFont=True as the default,
so what about switching it to "False"?

In my own stuff I use "False" (for a long time) as otherwise the masked
controls use a different font then the other controls, which doesn't
look great.

I think that would probably be okay. Can you make a patch that also updates the docstrings regarding the useFixedWidthFont default functionality.

Will work on that, shouldn't take too long if I don't run into issues.

5

I wondered about that too, thinking of masks with non-editable characters in them, like phone numbers. I think it would be okay to do it just for numctrl if that seems the best to you.

···

On 12/28/12 12:08 AM, Werner wrote:

On 27/12/2012 22:50, Werner wrote:

On 27/12/2012 22:41, Robin Dunn wrote:

On 12/26/12 11:37 PM, Werner wrote:

Hi Robin,

I am not finding an solution for that one, except maybe the following
suggestion.

Currently the mask controls use useFixedWidthFont=True as the default,
so what about switching it to "False"?

In my own stuff I use "False" (for a long time) as otherwise the masked
controls use a different font then the other controls, which doesn't
look great.

I think that would probably be okay. Can you make a patch that also
updates the docstrings regarding the useFixedWidthFont default
functionality.

Will work on that, shouldn't take too long if I don't run into issues.

What do I change?

All masked controls or just numctrl? I have done the later at the
moment as some multi field controls are behaving a bit odd if changed,
i.e. the field is smaller then expected and growth when one types
something into them.

--
Robin Dunn
Software Craftsman

6

Hi Robin,

...

All masked controls or just numctrl? I have done the later at the
moment as some multi field controls are behaving a bit odd if changed,
i.e. the field is smaller then expected and growth when one types
something into them.

I wondered about that too, thinking of masks with non-editable characters in them, like phone numbers. I think it would be okay to do it just for numctrl if that seems the best to you.

Attached the patch for numctrl only (it also includes the size change)

Werner

P.S.
Will try to work out the time issue

maskedit2.patch (2.28 KB)

···

On 29/12/2012 21:30, Robin Dunn wrote:

7

Thanks. In the future please make your patches from the root of the wxPython source tree so the full relative paths to the changed files will be in the patch file. It makes it a little easier to apply the patch that way.

···

On 12/30/12 3:02 AM, Werner wrote:

Hi Robin,

On 29/12/2012 21:30, Robin Dunn wrote:

...

All masked controls or just numctrl? I have done the later at the
moment as some multi field controls are behaving a bit odd if changed,
i.e. the field is smaller then expected and growth when one types
something into them.

I wondered about that too, thinking of masks with non-editable
characters in them, like phone numbers. I think it would be okay to
do it just for numctrl if that seems the best to you.

Attached the patch for numctrl only (it also includes the size change)

--
Robin Dunn
Software Craftsman

8

Hi Robin,

..

Thanks. In the future please make your patches from the root of the wxPython source tree so the full relative paths to the changed files will be in the patch file. It makes it a little easier to apply the patch that way.

Thanks for applying this one.

Will check out the full tree, up to now I only got AGW and masked on a regular basis.

Werner

···

On 31/12/2012 21:59, Robin Dunn wrote: