Robin Dunn wrote:
Jean-Michel Fauth wrote:
I suggest to change the function argument "required" by "force".¨
I find the name "force" more speaking.
Indeed, in a statement like:
r = checkInstalled('2.5', required='ansi')
"required" is ok. But in the statement
r = checkInstalled('2.5-unicode', required='ansi')
it sounds strange.
r = checkInstalled('2.5-unicode', force='ansi')
seems to me better.
Hmm... This ability to specify one and force another looks like a good
reason to do it the other way I proposed with just a boolean flag.
Please try the new version attached.
I like this new version, it seems to be ok. A plus is that
checkInstalled() and select() recognize a misspelled version
option name. This is not the case in ensureMinimal, anyway it
selected an "allowed" version.
In your test script I found:
# There isn't a unicode match for this one, but it will give the best
# available 2.4. Should it give an error instead? I don't think so...
test("2.4-unicode")
This can be discussed. I'm ok with it.
Jean-Michel Fauth, Switzerland.