My patch was ignored

wxPython Users
1

I have downloaded the latest Phoenix's source code and fixed softwareupdate.py and build Phoenix from my fixed source code. Then I thoroughtly tested softwareupdate after the build. It works perfectly on Python 2.7 and 3.x. And yes, I have find out what the sofrwareupdate is for before I have done any of previously mentioned things. I hope someone writes a unittest for softwareupdate because I have no idea how to do that. And then we can apply softwareupdate.patch to the master branch of Phoenix and the unittest for it as well.

···

-----Original message-----
From: Daniel Hyams
Sent: 20.03.2013, 16:28
To: wxpython-users@googlegroups.com
Subject: Re: [wxPython-users] My patch was ignored

Bostjan:

I'm not a wxPython developer, but I can venture a guess to try to save
Robin and others from having to reply:

1) it's probably not being ignored; you can't expect turnaround the moment
you submit a patch. It takes time; they are working on other things.
2) in your posts, you indicated that you didn't know what
wx.lib.softwareupdate was for. This strongly implies that the patch has
not been tested. While I'm sure it does correct one problem with
softwareupdate.py, is that it? Does the module work completely?
Submitting a patch is much more than just editing a couple of obvious
lines and submitting; you have to compile and test, and in this context,
test enough such that there can be a "stamp" that says that "yes, this
works under Phoenix".

On Wed, Mar 20, 2013 at 11:10 AM, "Boštjan Mejak" <mejak.bost@gmail.com>wrote:

Why was my patch for Phoenix/wx/lib/softwareupdate.py ignored after it was
updated to include the "Tags:" line?

--
You received this message because you are subscribed to the Google Groups
"wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to wxpython-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
Daniel Hyams
dhyams@gmail.com

--
You received this message because you are subscribed to the Google Groups "wxPython-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

2

OK, the reason that I posted what I did was because of this: https://groups.google.com/d/msg/wxpython-users/Qo1utvDzvk4/UJOV65yh9QEJ

So you went from not knowing what the module was for, to a complete compile/test/patch/compile/test again/submit in a day? I’m skeptical, but if you say so I believe you. The info that you post below is useful.

The reason #1 is still valid; the devs are busy, and will get to it when they can.

On the patch itself, it would be best if you opened a ticket on the wx trac, and submitted the fix there. This saves the devs some work. And give them some time; your patch showed up yesterday. If nothing has been done in (say) two weeks, maybe bump the thread and politely remind. A “why are you ignoring this” is rude, quite frankly.

···

On Wed, Mar 20, 2013 at 11:53 AM, “Boštjan Mejak” mejak.bost@gmail.com wrote:

I have downloaded the latest Phoenix’s source code and fixed softwareupdate.py and build Phoenix from my fixed source code. Then I thoroughtly tested softwareupdate after the build. It works perfectly on Python 2.7 and 3.x. And yes, I have find out what the sofrwareupdate is for before I have done any of previously mentioned things. I hope someone writes a unittest for softwareupdate because I have no idea how to do that. And then we can apply softwareupdate.patch to the master branch of Phoenix and the unittest for it as well.

-----Original message-----

From: Daniel Hyams

Sent: 20.03.2013, 16:28

To: wxpython-users@googlegroups.com

Subject: Re: [wxPython-users] My patch was ignored

Bostjan:

I’m not a wxPython developer, but I can venture a guess to try to save

Robin and others from having to reply:

  1. it’s probably not being ignored; you can’t expect turnaround the moment

you submit a patch. It takes time; they are working on other things.

  1. in your posts, you indicated that you didn’t know what

wx.lib.softwareupdate was for. This strongly implies that the patch has

not been tested. While I’m sure it does correct one problem with

softwareupdate.py, is that it? Does the module work completely?

Submitting a patch is much more than just editing a couple of obvious

lines and submitting; you have to compile and test, and in this context,

test enough such that there can be a “stamp” that says that "yes, this

works under Phoenix".

On Wed, Mar 20, 2013 at 11:10 AM, “Boštjan Mejak” mejak.bost@gmail.comwrote:

Why was my patch for Phoenix/wx/lib/softwareupdate.py ignored after it was

updated to include the “Tags:” line?

–

You received this message because you are subscribed to the Google Groups

“wxPython-users” group.

To unsubscribe from this group and stop receiving emails from it, send an

email to wxpython-users+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

–

Daniel Hyams

dhyams@gmail.com

–

You received this message because you are subscribed to the Google Groups “wxPython-users” group.

To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

–

You received this message because you are subscribed to the Google Groups “wxPython-users” group.

To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

–
Daniel Hyams
dhyams@gmail.com

3

"Boštjan Mejak" wrote:

I have downloaded the latest Phoenix's source code and fixed softwareupdate.py and build Phoenix from my fixed source code.

On ONE operating system?

···

--
Tim Roberts, timr@probo.com
Providenza & Boekelheide, Inc.

4

Boštjan Mejak wrote:

I have downloaded the latest Phoenix's source code and fixed
softwareupdate.py and build Phoenix from my fixed source code. Then I
thoroughtly tested softwareupdate after the build. It works perfectly
on Python 2.7 and 3.x.

Please describe how you "thoroughly tested". Most of the code in the module is not even executed unless it is running in a frozen application (made using py2exe, py2app, cx_Freeze, etc.) So like others I find it a little hard to believe that you went from zero to being able to create an application that is able to update itself, and all that goes along with that, in a day's time, and tested it thoroughly. Especially since last I heard py2exe doesn't support Py3 yet, and I also have some doubts about Esky on Py3 but that may have been resolved recently.

But wait, there's more... Since some of the modules imported from softwareupdate.py have not been py3-ported yet, and which definitely have old style print statements and other errors, I find it extremely unlikely that you even tested importing softwareupdate in a Python3 interpreter. So tell me, does your definition of "thoroughly" mean "not even the bare minimum"?

And yes, I have find out what the
sofrwareupdate is for before I have done any of previously mentioned
things. I hope someone writes a unittest for softwareupdate because I
have no idea how to do that.

The unittest docs are quite good, and there are only about 260 examples in the Phoenix/unittest folder that you could learn from. Or at least copy/paste from if learning something new doesn't seem like a good idea to you.

And then we can apply
softwareupdate.patch to the master branch of Phoenix and the unittest
for it as well.

Oh, and just because something doesn't get committed to svn immediately or an email doesn't get answered in a few minutes does not mean that it is ignored. It just means that you are not the center of my universe and I do not orbit around you catering to your every need.

BTW, as you can see here: Commits · RobinD42/Phoenix · GitHub the change was committed to my git repo yesterday, and it will eventually make it to svn.

···

--
Robin Dunn
Software Craftsman