Latest FNB 2.8 Branch

wxPython Dev
1

Hello (Andrea),

There is an error in the latest changes in the FlatNotebook.

Line 1280:

c = wx.MacThemeColour(Carbon.Appearance.kThemeBrushFocusHighlight)

There is no wx.MacThemeColour method on the 2.8 Branch, it only exists on the 2.9 branch. After reviewing the history files I am guessing you may have made your latest changes on the 2.9 branch and then just copied the file over to the 2.8 branch. As the changes to use wx.MacThemeColour on the 2.9 branch appear to have been made by Robin in r50627.

Suggest simply reverting to a slightly modified version of the previous code on the 2.8 branch.

brush = wx.Brush(wx.BLACK)
brush.MacSetTheme(Carbon.Appearance.kThemeBrushFocusHighlight)
self._focusPen = wx.Pen(brush.GetColour(), 2, wx.SOLID)

The 2.9 branch version can stay as is since in 2.9 Brush::MacSetTheme has been removed.

Thanks,

Cody

2

Hi Cody,

···

On 7/15/08, Cody Precord wrote:

Hello (Andrea),

There is an error in the latest changes in the FlatNotebook.

Line 1280:

c =
wx.MacThemeColour(Carbon.Appearance.kThemeBrushFocusHighlight)

There is no wx.MacThemeColour method on the 2.8 Branch, it only exists on
the 2.9 branch. After reviewing the history files I am guessing you may have
made your latest changes on the 2.9 branch and then just copied the file
over to the 2.8 branch. As the changes to use wx.MacThemeColour on the 2.9
branch appear to have been made by Robin in r50627.

Suggest simply reverting to a slightly modified version of the previous code
on the 2.8 branch.

brush = wx.Brush(wx.BLACK)
brush.MacSetTheme(Carbon.Appearance.kThemeBrushFocusHighlight)
self._focusPen = wx.Pen(brush.GetColour(), 2, wx.SOLID)

The 2.9 branch version can stay as is since in 2.9 Brush::MacSetTheme has
been removed.

Thank you for your report. I didn't know about this new method in 2.9,
I thought FlatNotebook was back-portable over 2.8. I'll change the SVN
source when I get back home tonight.

Andrea.

"Imagination Is The Only Weapon In The War Against Reality."
http://xoomer.alice.it/infinity77/

3

Hello,

···

On Jul 15, 2008, at 3:29 AM, Andrea Gavana wrote:

Thank you for your report. I didn't know about this new method in 2.9,
I thought FlatNotebook was back-portable over 2.8. I'll change the SVN
source when I get back home tonight.

No problem, I see that this issue was still there today so I hope you don't mind as I went ahead and made the correction.

Thanks,

Cody

4

Hi Cody,

···

On Fri, Jul 18, 2008 at 1:32 AM, Cody Precord wrote:

Hello,

On Jul 15, 2008, at 3:29 AM, Andrea Gavana wrote:

Thank you for your report. I didn't know about this new method in 2.9,
I thought FlatNotebook was back-portable over 2.8. I'll change the SVN
source when I get back home tonight.

No problem, I see that this issue was still there today so I hope you don't
mind as I went ahead and made the correction.

Sorry for the late reply, I just came back from Greece :smiley:
Thank you for having made the correction, it went out of my head as I
was busy in preparation for the holiday.

Andrea.

"Imagination Is The Only Weapon In The War Against Reality."
http://xoomer.alice.it/infinity77/