Alec Teal wrote:
Mark, it depends - what if this causes someone some weird bug that they
never realise is caused by this line? If you have to get a truth table
and compare the results for the two things.
No. There cannot possibly be any weird bugs caused by this change.
This is a stylistic thing, not a semantic thing.
The ONLY case in which "x != None" and "x is not None" can produce
different results is when "x" is an object that implements the __eq__
operator in some unusual and non-traditional way. That's not the case
here -- it's a string. I would have written
if not set_dir:
Mark is exactly right. In order of importance, this is probably about
12,000th on the list of wxPython problems. Bostjan should certainly
submit a bug report, but there is no justification for demanding a fix.
It's exactly like reporting a spelling error.
···
--
Tim Roberts, timr@probo.com
Providenza & Boekelheide, Inc.