HyperTreeList.GetFirstVisibleItem

Hi Andrea et al,

HyperTreeList.GetFirstVisibleItem is delegated to the
TreeListMainWindow. In other tree controls, GetFirstVisibleItems needs
no arguments (besides self). However,
TreeListMainWindow.GetFirstVisibleItem wants one argument called
'fullrow'. TreeListMainWindow.GetFirstVisibleItem looks like this:

    def GetFirstVisibleItem(self, fullRow):

        return self.GetNextVisible(self.GetRootItem(), fullRow)

TreeListMainWindow inherits the GetNextVisible method from
CustomTreeCtrl, but that method doesn't take a fullrow argument:

    def GetNextVisible(self, item):
        """Returns the next visible item."""

        [snip]

Is that fullrow argument needed at all? Looks to me like it can be
removed without consequences.

The same goes for TreeListMainWindow.GetPrevVisible that takes an
optional fullRow argument, calls self.IsItemVisible, but
TreeListMainWindow.IsItemVisible doesn't take a fullRow argument.

Thanks, Frank

Hi Frank & All,

···

On Sat, Apr 25, 2009 at 9:49 PM, Frank Niessink wrote:

Hi Andrea et al,

HyperTreeList.GetFirstVisibleItem is delegated to the
TreeListMainWindow. In other tree controls, GetFirstVisibleItems needs
no arguments (besides self). However,
TreeListMainWindow.GetFirstVisibleItem wants one argument called
'fullrow'. TreeListMainWindow.GetFirstVisibleItem looks like this:

def GetFirstVisibleItem(self, fullRow):

   return self\.GetNextVisible\(self\.GetRootItem\(\), fullRow\)

TreeListMainWindow inherits the GetNextVisible method from
CustomTreeCtrl, but that method doesn't take a fullrow argument:

def GetNextVisible(self, item):
"""Returns the next visible item."""

   \[snip\]

Is that fullrow argument needed at all? Looks to me like it can be
removed without consequences.

The same goes for TreeListMainWindow.GetPrevVisible that takes an
optional fullRow argument, calls self.IsItemVisible, but
TreeListMainWindow.IsItemVisible doesn't take a fullRow argument.

Thank you for the testing and for the patch on the previous message, I
have applied it and fixed this "fullRow" thing in SVN.

Andrea.

"Imagination Is The Only Weapon In The War Against Reality."
http://xoomer.alice.it/infinity77/