FlatNotebook "foreign" DND on Mac?

Hello all.

I was testing out using the “FNB_ALLOW_FOREIGN_DND” style with the FlatNotebook to see about dragging pages between books, and noticed on the Mac it didn’t seem to do anything. Investigating why, I noticed the flatnotebook.py code checked and only allowed it to occur on GTK or MSW platforms.

Soo. Curious what would happened since the actual code looked so simple, I added WXMAC to the list of allowed platforms in the code.

And it worked fine.

So-- I’m wondering, is there any reason or issue with this code that should prevent it from working on the Mac, that wasn’t apparent in my admittedly simple testing?

And if not, can we have it modified in the official distribution to allow? :slight_smile:

–Stephen

Stephen Hansen wrote:

Hello all.

I was testing out using the "FNB_ALLOW_FOREIGN_DND" style with the FlatNotebook to see about dragging pages between books, and noticed on the Mac it didn't seem to do anything. Investigating why, I noticed the flatnotebook.py code checked and only allowed it to occur on GTK or MSW platforms.

Soo. Curious what would happened since the actual code looked so simple, I added __WXMAC__ to the list of allowed platforms in the code.

And it worked fine.

So-- I'm wondering, is there any reason or issue with this code that should prevent it from working on the Mac, that wasn't apparent in my admittedly simple testing?

Probably just that Andrea doesn't have a Mac to test with.

And if not, can we have it modified in the official distribution to allow? :slight_smile:

Send me a patch.

···

--
Robin Dunn
Software Craftsman
http://wxPython.org Java give you jitters? Relax with wxPython!

Stephen Hansen wrote:

So-- I’m wondering, is there any reason or issue with this code that
should prevent it from working on the Mac, that wasn’t apparent in my
admittedly simple testing?

Probably just that Andrea doesn’t have a Mac to test with.

Just checking, as there were some other WXMAC details in the file.

And if not, can we have it modified in the official distribution to
allow? :slight_smile:

Send me a patch.

Alrighty. Sent to SF as #1661004.

–S

···

On 2/15/07, Robin Dunn robin@alldunn.com wrote:

HI Stephen,

Stephen Hansen wrote:
> Hello all.
>
> I was testing out using the "FNB_ALLOW_FOREIGN_DND" style with the
> FlatNotebook to see about dragging pages between books, and noticed on
> the Mac it didn't seem to do anything. Investigating why, I noticed the
> flatnotebook.py code checked and only allowed it to occur on GTK or MSW
> platforms.
>
> Soo. Curious what would happened since the actual code looked so simple,
> I added __WXMAC__ to the list of allowed platforms in the code.
>
> And it worked fine.
>
> So-- I'm wondering, is there any reason or issue with this code that
> should prevent it from working on the Mac, that wasn't apparent in my
> admittedly simple testing?

Probably just that Andrea doesn't have a Mac to test with.

>
> And if not, can we have it modified in the official distribution to
> allow? :slight_smile:

Send me a patch.

Sorry for the delay, I was on holiday. Yes, actually I don't have a
Mac to work with, so I simply thought that on Mac it wouldn't have
worked :smiley:
Glad it does!

Andrea.

"Imagination Is The Only Weapon In The War Against Reality."
http://xoomer.virgilio.it/infinity77/

···

On 2/15/07, Robin Dunn wrote: