ANN: Thumbs Critical Update

Hello people,

new version of my thumbnail control is attached.
This addresses the problem raised by Richard Terry.

I live and learn... :wink: I just hope that the multi-threading issue related to GUI calls in non GUI thread is solved.

Now all I need is a brave soul to test it on Linux and give the verdict! Is it solved?

As a side note some "strange" behaviour that I suspected to be caused by poor multithreading handling seams to have disappeared.
On Windows altho there was no dramatic breakage like the one Richard presented there was still this "strange", selection related problem upon opening the control (while the worker thread still created thumbnails). This problem seams to have disappeared so I hope is safe to try it on Linux :wink:

Peter.

thumbs.0.1a2.zip (6.47 KB)

Unfortunately no.

it gave me this traceback:

Traceback (most recent call last):
  File "thumbs.py", line 521, in OnPaint
    self.offDC.Clear()
  File
"/usr/lib/python2.4/site-packages/wx-2.6-gtk2-unicode/wx/_gdi.py", line
3286, in Clear
    return _gdi_.DC_Clear(*args, **kwargs)
wx._core.PyAssertionError: C++ assertion "wxAssertFailure" failed
in ../src/gtk/dcclient.cpp(1837): invalid window dc

than I moved the self.offDC.Clear one line bellow. After the
self.offDC.SelectObject(offscreenBMP) to correct the error but it keeps
to give the "Xlib: unexpected async reply" error.

On rare occasions it works, but it's very rare. I increase the sleep
times a little bit and it work more often but not always.

Ricardo

路路路

On Sat, 2005-12-17 at 09:39 +0200, Peter Damoc wrote:

Hello people,

new version of my thumbnail control is attached.
This addresses the problem raised by Richard Terry.

I live and learn... :wink: I just hope that the multi-threading issue related
to GUI calls in non GUI thread is solved.

Now all I need is a brave soul to test it on Linux and give the verdict!
Is it solved?

--

"Unix is very user-friendly. It's just picky about who its friends are."
http://rpedroso.freesuperhost.com/

I think I correct the problem on linux.

With the changes I wrote in previous reply I made another modification.
I pass the call to the Pil2BMP to the main thread.

I Attached the thumb ctrl with my modifications.
I call it thumb_rp.py, so you can unzip safely into the same place where
you have yours.

Ricardo

thumbs_rp.zip (6.61 KB)

路路路

On Sat, 2005-12-17 at 09:39 +0200, Peter Damoc wrote:

Hello people,

new version of my thumbnail control is attached.
This addresses the problem raised by Richard Terry.

I live and learn... :wink: I just hope that the multi-threading issue related
to GUI calls in non GUI thread is solved.

Now all I need is a brave soul to test it on Linux and give the verdict!
Is it solved?

--

"Unix is very user-friendly. It's just picky about who its friends are."
http://rpedroso.freesuperhost.com/