agw.aui panes + bug

Unfortunately, I was almost definitely the one who introduced this particular bug, so I don’t have that option :slight_smile:

In short, I had named the argument/pane that would become the notebook base the ‘target’, and in the code I shamelessly reused from DoDropFloatingPane, the pane that was about to be dropped was called the ‘target’. So I suppose I mixed them up…

I’ve attached patches for:

aui / framemanager.py - fixes above issue and also moves most of the duplicate code into it’s own function
demos / AUI.py - (Optional) Change to the demo which adds a third notebook page to the auto-nb to prove it’s fixed.

These two patches made against the latest SVN checkout (r64758)

  • Michael

autonb-multpanes-demo-20100626.patch (1.28 KB)

autonb-multiple-pane-fix-20100626.patch (4.07 KB)

The patch works great!

Does anybody know if Andrea is on holidays? I've sent two patches (ribbon, aui tabart) to him in private mail two weeks ago. Maybe we should put our patches on the bug tracker as well, so they don't get lost til he's back.

-Matthias

···

Am 27.06.2010, 00:28 Uhr, schrieb michael h <michaelkenth@gmail.com>:

Unfortunately, I was almost definitely the one who introduced this
particular bug, so I don't have that option :slight_smile:

In short, I had named the argument/pane that would become the notebook base
the 'target', and in the code I shamelessly reused from DoDropFloatingPane,
the pane that was about to be dropped was called the 'target'. So I suppose
I mixed them up..

I've attached patches for:

aui / framemanager.py - fixes above issue and also moves most of the
duplicate code into it's own function
demos / AUI.py - (Optional) Change to the demo which adds a third notebook
page to the auto-nb to prove it's fixed.

These two patches made against the latest SVN checkout (r64758)

Hey Andrea,

thanks for your status update. I hope the next four weeks pass by fast for you.

I'll put my stuff on trac in the meantime.

-Matthias

···

Am 27.06.2010, 11:25 Uhr, schrieb Andrea Gavana <andrea.gavana@gmail.com>:

Not on holiday, I am working rotation shifts between Kazakhstan and
Greece, and it is a bit hard at the moment to adapt and keep up with
everything. I did some work on AGW when I went home (3 weeks ago) but
here in Kazakhstan I work very long hours and don't have the strength
(nor the tools available, like SVN connection which is always blocked
by our firewall, so I should let someone else apply the patches to
AGW) to update it now.

I should be back to Greece in 4 weeks: by all means please post your
patches to the Trac, otherwise they risk of being lost.

I went to post mine as well, saw that you had already done it, thanks.

- michael

···

On Jun 29, 7:16 am, Nitro <nitrogen...@googlemail.com> wrote:

Am 27.06.2010, 11:25 Uhr, schrieb Andrea Gavana <andrea.gav...@gmail.com>:

> Not on holiday, I am working rotation shifts between Kazakhstan and
> Greece, and it is a bit hard at the moment to adapt and keep up with
> everything. I did some work on AGW when I went home (3 weeks ago) but
> here in Kazakhstan I work very long hours and don't have the strength
> (nor the tools available, like SVN connection which is always blocked
> by our firewall, so I should let someone else apply the patches to
> AGW) to update it now.

> I should be back to Greece in 4 weeks: by all means please post your
> patches to the Trac, otherwise they risk of being lost.

Hey Andrea,

thanks for your status update. I hope the next four weeks pass by fast for
you.

I'll put my stuff on trac in the meantime.

-Matthias

No problem.

I've noticed another problem with the auto notebooks. Say you have two panes with paneInfo.DestroyOnClose(False) in your auto notebook. Now you close one of the panes - this will effectively hide the pane and the auto-notebook will be destroyed, leaving you with a single "normal" pane.
If you call Show() on the hidden pane now the view will be all messed up. It seems the Show() does not cause the notebook to be recreated in this case and the hidden window doesn't have a parent window anymore.

Any idea for this?
-Matthias

···

Am 30.06.2010, 02:23 Uhr, schrieb michael h <michaelkenth@gmail.com>:

I went to post mine as well, saw that you had already done it, thanks.