A message for vadz

Hello, vadz :slight_smile:

I think I know why does the test fail... Please examine this line of code:
https://github.com/wxWidgets/commit/5cbb4a59ce0ae0ac4e3ed4d86d4338a497ceeab2#L0R205

Notice in the line 205 of this code that __WXGTKK__ should be fixed to __WXGTK__ (one K deleted).

I hope that'll fix the test. Please report back if it did or not.

Hi Bo�tjan,

Vadim Zeitlin (vadz) is a wxWidget core developer, I don't think he follows this list.

Maybe post a comment on github.

Werner

···

On 10/05/2013 09:12, "Bo�tjan Mejak" wrote:

Hello, vadz :slight_smile:

I think I know why does the test fail... Please examine this line of code:
https://github.com/wxWidgets/commit/5cbb4a59ce0ae0ac4e3ed4d86d4338a497ceeab2#L0R205

Notice in the line 205 of this code that __WXGTKK__ should be fixed to __WXGTK__ (one K deleted).

I hope that'll fix the test. Please report back if it did or not.

Anyway, what you’re wanting him to correct is just a comment. It won’t change execution in any way, obviously.

···

On Fri, May 10, 2013 at 4:05 AM, werner wbruhin@free.fr wrote:

Hi Boštjan,

Vadim Zeitlin (vadz) is a wxWidget core developer, I don’t think he follows this list.

Maybe post a comment on github.

Werner

On 10/05/2013 09:12, “Boštjan Mejak” wrote:

Hello, vadz :slight_smile:

I think I know why does the test fail… Please examine this line of code:

https://github.com/wxWidgets/commit/5cbb4a59ce0ae0ac4e3ed4d86d4338a497ceeab2#L0R205

Notice in the line 205 of this code that WXGTKK should be fixed to WXGTK (one K deleted).

I hope that’ll fix the test. Please report back if it did or not.

You received this message because you are subscribed to the Google Groups “wxPython-users” group.

To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.


Daniel Hyams
dhyams@gmail.com

I don’t think the # sign is used for comments in C++.

···

On Fri, May 10, 2013 at 12:53 PM, Daniel Hyams dhyams@gmail.com wrote:

Anyway, what you’re wanting him to correct is just a comment. It won’t change execution in any way, obviously.

You received this message because you are subscribed to the Google Groups “wxPython-users” group.

To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

On Fri, May 10, 2013 at 4:05 AM, werner wbruhin@free.fr wrote:

Hi Boštjan,

Vadim Zeitlin (vadz) is a wxWidget core developer, I don’t think he follows this list.

Maybe post a comment on github.

Werner

On 10/05/2013 09:12, “Boštjan Mejak” wrote:

Hello, vadz :slight_smile:

I think I know why does the test fail… Please examine this line of code:

https://github.com/wxWidgets/commit/5cbb4a59ce0ae0ac4e3ed4d86d4338a497ceeab2#L0R205

Notice in the line 205 of this code that WXGTKK should be fixed to WXGTK (one K deleted).

I hope that’ll fix the test. Please report back if it did or not.

You received this message because you are subscribed to the Google Groups “wxPython-users” group.

To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.


Daniel Hyams
dhyams@gmail.com

No, obviously not. You’re missing the // on the same line, which begins a C++ comment. Are you trying to tell me that the misspelling of WXGTK below affects the execution of the code? I hope not…

#endif // WGTKK

···

On Fri, May 10, 2013 at 8:50 AM, Boštjan Mejak mejak.bost@gmail.com wrote:

I don’t think the # sign is used for comments in C++.

You received this message because you are subscribed to the Google Groups “wxPython-users” group.

To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.


Daniel Hyams
dhyams@gmail.com

On Fri, May 10, 2013 at 12:53 PM, Daniel Hyams dhyams@gmail.com wrote:

Anyway, what you’re wanting him to correct is just a comment. It won’t change execution in any way, obviously.

You received this message because you are subscribed to the Google Groups “wxPython-users” group.

To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

On Fri, May 10, 2013 at 4:05 AM, werner wbruhin@free.fr wrote:

Hi Boštjan,

Vadim Zeitlin (vadz) is a wxWidget core developer, I don’t think he follows this list.

Maybe post a comment on github.

Werner

On 10/05/2013 09:12, “Boštjan Mejak” wrote:

Hello, vadz :slight_smile:

I think I know why does the test fail… Please examine this line of code:

https://github.com/wxWidgets/commit/5cbb4a59ce0ae0ac4e3ed4d86d4338a497ceeab2#L0R205

Notice in the line 205 of this code that WXGTKK should be fixed to WXGTK (one K deleted).

I hope that’ll fix the test. Please report back if it did or not.

You received this message because you are subscribed to the Google Groups “wxPython-users” group.

To unsubscribe from this group and stop receiving emails from it, send an email to wxpython-users+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.


Daniel Hyams
dhyams@gmail.com

Ah, yes… There’s the // in front of WXGTKK, so that’s a comment. The comment still deserves a typo fix, though, if anyone cares about those pedantic things that is.