Second point. I did not look at the pyShell code, I wonder if it
is necessary to use or to (re)define these Ctrl+[ and - Ctrl+]
commands. By default, Scintilla uses the Ctrl+numpad_+ and
Ctrl+numpad_- to increase and decrease the font size and
Ctrl+numpad_/ to restore the default setting. These Ctrl+[ and
and Ctrl+] seems redundant. In my psi shell, I am using the
Scintilla default behaviour and it is perfectly working.
I took a quick look at the code:
If I comment the lines 533+ in the file shell.py
# Increase font size.
#~ elif controlDown and key in (ord(']'),):
#~ dispatcher.send(signal='FontIncrease')
# Decrease font size.
#~ elif controlDown and key in (ord('['),):
#~ dispatcher.send(signal='FontDecrease')
# Default font size.
#~ elif controlDown and key in (ord('='),):
#~ dispatcher.send(signal='FontDefault')
the Ctrl+[ and Ctrl+] and Ctrl+= are disabled, the
increasing and decreasing default Scintilla behavior
Ctrl+numpad_-, +, / is perfectly working.
I suggest to remove these shortcuts and keep the default
ones. It will work on all keyboards.
the Ctrl+[ and Ctrl+] and Ctrl+= are disabled, the
increasing and decreasing default Scintilla behavior
Ctrl+numpad_-, +, / is perfectly working.
I suggest to remove these shortcuts and keep the default
ones. It will work on all keyboards.
We'll still want to do something there because the dispatcher.send(signal='FontIncrease') is used to signal the other windows in PyCrust to also zoom their fonts. Hmm... Looks like there is a EVT_STC_ZOOM that we can use instead...
···
--
Robin Dunn
Software Craftsman http://wxPython.org Java give you jitters? Relax with wxPython!
the Ctrl+[ and Ctrl+] and Ctrl+= are disabled, the
increasing and decreasing default Scintilla behavior
Ctrl+numpad_-, +, / is perfectly working.
I suggest to remove these shortcuts and keep the default
ones. It will work on all keyboards.
We'll still want to do something there because the dispatcher.send(signal='FontIncrease') is used to signal the other windows in PyCrust to also zoom their fonts. Hmm... Looks like there is a EVT_STC_ZOOM that we can use instead...
Okay, I've removed all the Ctrl-Alt accelerators. I didn't replace them with something else because I didn't feel that they were things that needed accelerators anyway. I got the feeling that they were given accelerators just for the sake of giving everything in the menu an accelerator, not becuase they would typically be used often while typing in the shell.
Also, I've left the Ctrl-[=] for zooming in place in case people are used to using it, and have added Ctrl-numpad-+/- to also send the dispatcher signals so they can be used for the same functionality of changing the zoom for all windows.
Does that take care of the non-U.S. keyboard issues in PyCrust/PyShell?
···
--
Robin Dunn
Software Craftsman http://wxPython.org Java give you jitters? Relax with wxPython!