20050524 test build uploaded

Hi,

A new test build of wxPython has been uploaded to starship.

   Version: 2.6.0.1pre.20050524
   URL: http://starship.python.net/crew/robind/wxPython/daily/20050524
   Changes: http://starship.python.net/crew/robind/wxPython/daily/20050524/CHANGES.html

Have fun!
R'bot

Qua, 2005-05-25 às 00:30 -0700, R'bot escreveu:

Hi,

A new test build of wxPython has been uploaded to starship.

   Version: 2.6.0.1pre.20050524

There are 2 issues in this pre release:

1)
A wxwidgets problem:
   wxCalendarCtrl segfaults when we have the
   wxCAL_SEQUENTIAL_MONTH_SELECTION set

I've made a patch to correct this:

$ diff src/generic/calctrl.cpp.ori src/generic/calctrl.cpp
756c756
< }

···

---

760a761

    }

894c895
< dc.DrawRectangle(x0, y, GetClientSize().x, m_heightRow);
---

        dc.DrawRectangle(0, y, GetClientSize().x, m_heightRow);

Note: I only tested with the gtk2 port

Robin, it's ok to make a patch like this and send to the mailing list or
you and the rest of the wx developers prefer a patch submited on
sourceforge? I'm asking this because I had send a simple patch like this
to wx-dev about a wxComboBox size issue on gtk2 and I think that it was
ignored. :frowning:

2) A wxPython demo problem:
   Robin, maybe you already notice but the StyledTextCtrl_1 demo gives
   an exception. ('module' object has no attribute 'getFolder1Bitmap').
   I know you are changing the icons, bitmap, ..., etc, as you mention
   in other thread.

Ricardo

894c895
< dc.DrawRectangle(x0, y, GetClientSize().x, m_heightRow);
---
> dc.DrawRectangle(0, y, GetClientSize().x, m_heightRow);

Ups, I forgot to mention, the change above is just for a cosmetic issue.
I must get to sleep, it's almost 6:00 am in my country.

Ricardo

Ricardo Pedroso wrote:

Qua, 2005-05-25 às 00:30 -0700, R'bot escreveu:

Hi,

A new test build of wxPython has been uploaded to starship.

  Version: 2.6.0.1pre.20050524

There are 2 issues in this pre release:

1)
A wxwidgets problem:
   wxCalendarCtrl segfaults when we have the wxCAL_SEQUENTIAL_MONTH_SELECTION set

I've made a patch to correct this:

$ diff src/generic/calctrl.cpp.ori src/generic/calctrl.cpp
756c756
< }
---

760a761

   }

894c895
< dc.DrawRectangle(x0, y, GetClientSize().x, m_heightRow);
---

       dc.DrawRectangle(0, y, GetClientSize().x, m_heightRow);

Note: I only tested with the gtk2 port

Robin, it's ok to make a patch like this and send to the mailing list or
you and the rest of the wx developers prefer a patch submited on
sourceforge?

If it's wxPython specific or very simple then it's okay to send them to me or to this list. Otherwise make a patch record at the sourceforge tracker.

BTW, it's best to use the "unified" diff format (using the -u flag) because then if there are problems applying the patch they can usually be tweaked or applied to the source by hand. Please recreate the above patch using -u.

2) A wxPython demo problem:
   Robin, maybe you already notice but the StyledTextCtrl_1 demo gives
   an exception. ('module' object has no attribute 'getFolder1Bitmap').
   I know you are changing the icons, bitmap, ..., etc, as you mention
   in other thread.

Thanks.

···

--
Robin Dunn
Software Craftsman
http://wxPython.org Java give you jitters? Relax with wxPython!

Qui, 2005-05-26 às 09:16 -0700, Robin Dunn escreveu:

If it's wxPython specific or very simple then it's okay to send them to
me or to this list. Otherwise make a patch record at the sourceforge
tracker.

BTW, it's best to use the "unified" diff format (using the -u flag)
because then if there are problems applying the patch they can usually
be tweaked or applied to the source by hand. Please recreate the above
patch using -u.

Attached are the two patchs in unified diff format. They are wxwidgets specific but very simple.

Ricardo

calctrl_segfault.patch (897 Bytes)

combobox_size.patch (338 Bytes)

Ricardo Pedroso wrote:

Attached are the two patchs in unified diff format. They are wxwidgets specific but very simple.

Thanks.

--- src/gtk/window.cpp.ori 2005-05-26 17:26:51.000000000 +0100
+++ src/gtk/window.cpp 2005-05-26 15:33:29.000000000 +0100
@@ -507,7 +507,7 @@
         (gcombo->button, &entry_req );
          requisition->width = w - entry_req.width;
- requisition->height = entry_req.height;
+ requisition->height = h; //entry_req.height;

Using h here made the combobox too small, so instead I just removed the +4 like in your original patch.

···

--
Robin Dunn
Software Craftsman
http://wxPython.org Java give you jitters? Relax with wxPython!

Qui, 2005-05-26 às 10:43 -0700, Robin Dunn escreveu:

>
> --- src/gtk/window.cpp.ori 2005-05-26 17:26:51.000000000 +0100
> +++ src/gtk/window.cpp 2005-05-26 15:33:29.000000000 +0100
> @@ -507,7 +507,7 @@
> (gcombo->button, &entry_req );
>
> requisition->width = w - entry_req.width;
> - requisition->height = entry_req.height;
> + requisition->height = h; //entry_req.height;

Using h here made the combobox too small, so instead I just removed the
+4 like in your original patch.

I don't think it's too small with "h". I just want to give to the
combobox the same size of a textctrl.

if you have "requisition->height = entry_req.height" the user will not
be able to give a size to combobox.

Try two simple tests attached with h and without "h".
The first one is without a sizer the second is with a gridsizer.
With "h", there is a small issue when we give a -1 height, the combobox
and the textctrl will not be vertically aligned.

Ricardo

ComboSizeTest2.py (881 Bytes)

ComboSizeTest1.py (582 Bytes)

Ricardo Pedroso wrote:

Qui, 2005-05-26 às 10:43 -0700, Robin Dunn escreveu:

--- src/gtk/window.cpp.ori 2005-05-26 17:26:51.000000000 +0100
+++ src/gtk/window.cpp 2005-05-26 15:33:29.000000000 +0100
@@ -507,7 +507,7 @@
        (gcombo->button, &entry_req );
        requisition->width = w - entry_req.width;
- requisition->height = entry_req.height;
+ requisition->height = h; //entry_req.height;

Using h here made the combobox too small, so instead I just removed the +4 like in your original patch.

I don't think it's too small with "h". I just want to give to the
combobox the same size of a textctrl.

For my current settings using just h will result in a height that is three pixels smaller than a textctrl. Perhaps what should be done is to do the requisition on the textctrl part of the combo instead of the button part. In either case this will probably need some more discussion on wx-dev so please bring it up there again and give enough details that non-Python folks can understand what the problem is.

···

--
Robin Dunn
Software Craftsman
http://wxPython.org Java give you jitters? Relax with wxPython!